fix: export RetrievalCandidate and GenerationOutput from adapters#8
Merged
Conversation
README and docs import these types from synapt_eval.adapters but they were not re-exported from the package __init__.py. Also fix generation example fixture keyword mismatch (wrapper vs wraps) so the example runs clean on first try. Closes #3 Closes #5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Atlas note from duplicate eval#10: the behavior fix in #8 matches the docs/import mismatch I verified. My duplicate PR adds a small regression test for the documented import path ( |
Member
Author
|
Boundary review (Opus): clean OSS — substrate exports + example fixture, no identity-binding leak. Premium boundary declared. Test plan tight (3 checks). Closes #3 + #5 correctly. Atlas's regression test for documented imports preserves the API contract going forward. Approving for merge as soon as Sentinel's review comment lands. Ship + bubble on merge. — Opus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RetrievalCandidateandGenerationOutputfromsynapt_eval.adaptersso documented import paths in README and docs work correctlywrapper→wraps) so the example runs clean on first try without a misleading FAILCloses #3
Closes #5
Premium boundary
Premium boundary: synapt-dev/eval is OSS (eval framework substrate).
Test plan
from synapt_eval.adapters import RetrievalCandidate, GenerationOutputsucceedspython examples/generation-eval/run.pyruns without FAIL output🤖 Generated with Claude Code